Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design : 학사 일정 디자인 QA 반영 #203

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Conversation

huiwoo-jo
Copy link
Contributor

@huiwoo-jo huiwoo-jo commented Mar 26, 2024

📮 관련 이슈

✍️ 구현 내용

  • 년/월 텍스트 사이즈를 16sp에서 16dp로 변경하였습니다.
  • 년/월 설정의 화살표 디자인과 색상을 변경하였습니다.
  • 학사일정 아이템의 날짜의 줄바꿈 부분을 물결표 이후에서 이전으로 변경하였습니다.
  • 학사일정 아이템의 paddingVertical의 값을 조정하였습니다.

📷 구현 영상

  • image

✔️ 확인 사항

  • 컨벤션에 맞는 PR 타이틀
  • 관련 이슈 연결
  • PR 관련 정보 연결 (작업자, 라벨, 마일스톤 등)
  • Github Action 통과

@huiwoo-jo huiwoo-jo added 🎨 DESIGN User interface design 🩵희우 labels Mar 26, 2024
@huiwoo-jo huiwoo-jo requested review from hoyahozz and m6z1 March 26, 2024 06:16
@huiwoo-jo huiwoo-jo self-assigned this Mar 26, 2024
Copy link
Collaborator

@m6z1 m6z1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 머지합시다요

app/src/main/res/layout/item_schedule.xml Outdated Show resolved Hide resolved
@huiwoo-jo huiwoo-jo merged commit 01dd2bf into develop Mar 26, 2024
1 check passed
@huiwoo-jo huiwoo-jo deleted the design/schedule-ui branch March 26, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 DESIGN User interface design 🩵희우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

학사 일정 디자인 QA
2 participants